linux-kernel - Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161231090400.GB16976@gondor.apana.org.au>
Date:   Sat, 31 Dec 2016 17:04:00 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     gidisrael@...il.com
Cc:     davem@...emloft.net, nhorman@...driver.com,
        akpm@...ux-foundation.org, geert@...ux-m68k.org, joe@...ches.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel:
 use macros from compiler.h instead of __attribute__((...))")

On Sat, Dec 31, 2016 at 06:11:13AM +0530, gidisrael@...il.com wrote:
> From: Gideon Israel Dsouza <gidisrael@...il.com>
> 
> Very sorry about the previous broken patch. Here is an updated one.
> 
> I submitted 4 total patches. They are part of task I've taken up to
> increase compiler portability in the kernel. I've cleaned up the
> subsystems under /kernel /mm /block and /security, this patch targets
> /crypto.
> 
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for the crypto
> subsystem.
> 
> I had to make one additional change into compiler-gcc.h for the case when
> one wants to use this: __attribute__((aligned) and not specify an alignment
> factor. From the gcc docs, this will result in the largest alignment for
> that data type on the target machine so I've named the macro
> __aligned_largest. Please advise if another name is more appropriate.
> 
> RFC: There are many places where __attribute((unused)) is used. There are
> two macros for the exact same macro inside compiler-gcc.h:
> __always_unused and __maybe_unused. I'm not sure which to have used to
> replace instances inside /crypto. Should there perhaps be just an unused
> macro. There are 1830 instances of __maybe_unused inside the kernel
> code and 110 uses of__always_unused excluding my changes.
> 
> Signed-off-by: Gideon Israel Dsouza <gidisrael@...il.com>

Please send crypto patches to linux-crypto@...r.kernel.org.

>  static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;

You should use __maybe_unused.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt