linux-kernel - Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 31 Dec 2016 08:31:20 -0800
From:   Joe Perches <joe@...ches.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     gidisrael@...il.com, davem@...emloft.net, nhorman@...driver.com,
        akpm@...ux-foundation.org, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel:
 use macros from compiler.h instead of __attribute__((...))")

On Sat, 2016-12-31 at 17:03 +0800, Herbert Xu wrote:
> On Fri, Dec 30, 2016 at 04:49:28PM -0800, Joe Perches wrote:
> > 
> > Perhaps it'd be better to remove the declaration/prototype
> > of crypto_ablkcipher_show and surround the definition of
> > crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif
> 
> No that's stupid.  We want to maximise the compiler coverage.

stupid is rather a strong word for the most
common technique used in the kernel to avoid
compiler warnings.