lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Jan 2017 16:48:41 +0100 From: Jan Kara <jack@...e.cz> To: Minchan Kim <minchan@...nel.org> Cc: Tim Chen <tim.c.chen@...ux.intel.com>, Andrew Morton <akpm@...ux-foundation.org>, Ying Huang <ying.huang@...el.com>, dave.hansen@...el.com, ak@...ux.intel.com, aaron.lu@...el.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>, Shaohua Li <shli@...nel.org>, Rik van Riel <riel@...hat.com>, Andrea Arcangeli <aarcange@...hat.com>, "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>, Vladimir Davydov <vdavydov.dev@...il.com>, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, Hillf Danton <hillf.zj@...baba-inc.com>, Christian Borntraeger <borntraeger@...ibm.com>, Jonathan Corbet <corbet@....net>, jack@...e.cz Subject: Re: [PATCH v4 0/9] mm/swap: Regular page swap optimizations Hi, On Tue 27-12-16 16:45:03, Minchan Kim wrote: > > Patch 3 splits the swap cache radix tree into 64MB chunks, reducing > > the rate that we have to contende for the radix tree. > > To me, it's rather hacky. I think it might be common problem for page cache > so can we think another generalized way like range_lock? Ccing Jan. I agree on the hackyness of the patch and that page cache would suffer with the same contention (although the files are usually smaller than swap so it would not be that visible I guess). But I don't see how range lock would help here - we need to serialize modifications of the tree structure itself and that is difficult to achieve with the range lock. So what you would need is either a different data structure for tracking swap cache entries or a finer grained locking of the radix tree. Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists