linux-kernel - Re: [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYOq_v2N7q3P1C=Q2u8K1Jdhjem_Ry+v2r9f+ik_gKGqg@mail.gmail.com>
Date:   Mon, 2 Jan 2017 22:43:43 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Gary Bisson <gary.bisson@...ndarydevices.com>
Cc:     Fabio Estevam <fabio.estevam@....com>,
        ext Tony Lindgren <tony@...mide.com>,
        Shawn Guo <shawnguo@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers

On Mon, Jan 2, 2017 at 7:20 PM, Gary Bisson
<gary.bisson@...ndarydevices.com> wrote:

> This series is a follow-up to Linus suggestion to use the generic helpers
> introduced by Tony [1].
>
> Mainly I've used the generic functions in pinctrl_ops and pinmux_ops and
> switched to the generic group/function_desc structures instead of the
> imx-specific one that didn't bring anything special.

Awesome job. Really nice!

> However I couldn't use the 'add' functions to add elements since the
> parsing is done at probe time in its own way. So I've kept the
> radix_insert functions. This could be modified in the future though.

Let's see if Tony has some ideas. We already save a bunch of
code by this which is very nice.

Yours,
Linus Walleij