linux-kernel - hwmon: w83781d: Unused sysfs group w83781d_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1483393793-28724-1-git-send-email-khoroshilov@ispras.ru>
Date:   Tue,  3 Jan 2017 00:49:53 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: hwmon: w83781d: Unused sysfs group w83781d_group_other

Hello,

w83781d.c contains a definition of sysfs group:

static const struct attribute_group w83781d_group_other = {
	.attrs = w83781d_attributes_other,
};

the only usage of which is:

static void w83781d_remove_files(struct device *dev)
{
	...
	sysfs_remove_group(&dev->kobj, &w83781d_group_other);
}

So, it seems the group should be either created in w83781d_create_files() or removed completely.
What do you think?

Found by Linux Driver Verification project (linuxtesting.org).

--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org