linux-kernel - Re: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 02 Jan 2017 09:32:15 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kbuild test robot <fengguang.wu@...el.com>,
        Paul Burton <paul.burton@...tec.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        user-mode-linux-devel@...ts.sourceforge.net,
        Lee Jones <lee.jones@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM

On Sunday, January 1, 2017 6:42:38 PM CET Randy Dunlap wrote:
> --- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc2/drivers/auxdisplay/Kconfig
> @@ -121,6 +121,7 @@ config CFAG12864B_RATE
>  
>  config IMG_ASCII_LCD
>         tristate "Imagination Technologies ASCII LCD Display"
> +       depends on HAS_IOMEM
>         default y if MIPS_MALTA || MIPS_SEAD3
>         select SYSCON
>         help

Maybe "depends on MIPS || COMPILE_TEST" instead?

That hides the symbol for most people that don't really want the driver
anyway, and it takes care of HAS_IOMEM for UML as well.

	Arnd