linux-kernel - Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <271b3ede-b784-07f2-8028-19be4ea7fcbd@baylibre.com>
Date:   Mon, 2 Jan 2017 09:33:27 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mtd@...ts.infradead.org
Cc:     kbuild test robot <fengguang.wu@...el.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um,
 require HAS_IOMEM

On 01/02/2017 03:58 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors on arch/um, which does not support HAS_IOMEM,
> while the oxnas_nand.c driver uses interfaces that are
> supplied by HAS_IOMEM.
> 
> (loadable module build:)
> ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
> or (built-in build:)
> drivers/built-in.o: In function `oxnas_nand_probe':
> drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Cc: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc:	Jeff Dike <jdike@...toit.com>
> Cc:	Richard Weinberger <richard@....at>
> Cc:	user-mode-linux-devel@...ts.sourceforge.net
> Cc:	linux-mtd@...ts.infradead.org
> ---
>  drivers/mtd/nand/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
> +++ lnx-410-rc2/drivers/mtd/nand/Kconfig
> @@ -426,6 +426,7 @@ config MTD_NAND_ORION
>  
>  config MTD_NAND_OXNAS
>  	tristate "NAND Flash support for Oxford Semiconductor SoC"
> +	depends on HAS_IOMEM
>  	help
>  	  This enables the NAND flash controller on Oxford Semiconductor SoCs.
>  
> 

Thanks Randy,

Acked-by: Neil Armstrong <narmstrong@...libre.com>