linux-kernel - Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170104100800.334a9a0e@gandalf.local.home>
Date:   Wed, 4 Jan 2017 10:08:00 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>
Cc:     Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        "H. Peter Anvin" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Nicolai Stange <nicstange@...il.com>,
        Gu Zheng <guz.fnst@...fujitsu.com>,
        Baoquan He <bhe@...hat.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Claudio Fontana <claudio.fontana@...wei.com>,
        Aaron Lu <aaron.lu@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Wanpeng Li <wanpeng.li@...mail.com>,
        Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
        linux-edac@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's
 platform IRQ handlers

On Wed,  4 Jan 2017 12:20:33 +0100
Daniel Bristot de Oliveira <bristot@...hat.com> wrote:

> This patch adds the __irq_entry annotation to the defaults x86's
> platform IRQ handlers. ftrace's function_graph tracer uses the
> __irq_entry annotation to notify the entry and return of IRQ
> handlers.
> 
> For example, before the patch:
>   354549.667252 |   3)  d..1              |  default_idle_call() {
>   354549.667252 |   3)  d..1              |    arch_cpu_idle() {
>   354549.667253 |   3)  d..1              |      default_idle() {
>   354549.696886 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
>   354549.696886 |   3)  d..1              |          irq_enter() {
>   354549.696886 |   3)  d..1              |            rcu_irq_enter() {
> 
> After the patch:
>   366416.254476 |   3)  d..1              |    arch_cpu_idle() {
>   366416.254476 |   3)  d..1              |      default_idle() {
>   366416.261566 |   3)  d..1  ==========> |
>   366416.261566 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
>   366416.261566 |   3)  d..1              |          irq_enter() {
>   366416.261566 |   3)  d..1              |            rcu_irq_enter() {
> 
> KASAN also uses this annotation. The smp_apic_timer_interrupt
> was already annotated.

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Thomas or Ingo, want to take this in tip?

-- Steve

> 
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dou Liyang <douly.fnst@...fujitsu.com>
> Cc: Nicolai Stange <nicstange@...il.com>
> Cc: Gu Zheng <guz.fnst@...fujitsu.com>
> Cc: Baoquan He <bhe@...hat.com>
> Cc: Denys Vlasenko <dvlasenk@...hat.com>
> Cc: Claudio Fontana <claudio.fontana@...wei.com>
> Cc: Aaron Lu <aaron.lu@...el.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Wanpeng Li <wanpeng.li@...mail.com>
> Cc: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-edac@...r.kernel.org
> Cc: x86@...nel.org