linux-kernel - Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170105075914.GB2098@gmail.com>
Date:   Thu, 5 Jan 2017 08:59:14 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        "H. Peter Anvin" <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Nicolai Stange <nicstange@...il.com>,
        Gu Zheng <guz.fnst@...fujitsu.com>,
        Baoquan He <bhe@...hat.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Claudio Fontana <claudio.fontana@...wei.com>,
        Aaron Lu <aaron.lu@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Wanpeng Li <wanpeng.li@...mail.com>,
        Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
        linux-edac@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform
 IRQ handlers


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed,  4 Jan 2017 12:20:33 +0100
> Daniel Bristot de Oliveira <bristot@...hat.com> wrote:
> 
> > This patch adds the __irq_entry annotation to the defaults x86's
> > platform IRQ handlers. ftrace's function_graph tracer uses the
> > __irq_entry annotation to notify the entry and return of IRQ
> > handlers.
> > 
> > For example, before the patch:
> >   354549.667252 |   3)  d..1              |  default_idle_call() {
> >   354549.667252 |   3)  d..1              |    arch_cpu_idle() {
> >   354549.667253 |   3)  d..1              |      default_idle() {
> >   354549.696886 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
> >   354549.696886 |   3)  d..1              |          irq_enter() {
> >   354549.696886 |   3)  d..1              |            rcu_irq_enter() {
> > 
> > After the patch:
> >   366416.254476 |   3)  d..1              |    arch_cpu_idle() {
> >   366416.254476 |   3)  d..1              |      default_idle() {
> >   366416.261566 |   3)  d..1  ==========> |
> >   366416.261566 |   3)  d..1              |        smp_trace_reschedule_interrupt() {
> >   366416.261566 |   3)  d..1              |          irq_enter() {
> >   366416.261566 |   3)  d..1              |            rcu_irq_enter() {
> > 
> > KASAN also uses this annotation. The smp_apic_timer_interrupt
> > was already annotated.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 
> Thomas or Ingo, want to take this in tip?

Yeah, queued it up for v4.11.

Thanks,

	Ingo