linux-kernel - Re: [PATCH] scsi: qedi: return via va_end to match corresponding va

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1d1g2kr6z.fsf@oracle.com>
Date:   Thu, 05 Jan 2017 00:32:04 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     QLogic-Storage-Upstream@...ium.com,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start

>>>>> "Colin" == Colin King <colin.king@...onical.com> writes:

Colin> Although on most systems va_end is a no-op, it is good practice
Colin> to use va_end on the function return path, especially since the
Colin> va_start documenation states:

Colin>   "Each invocation of va_start() must be matched by a
Colin>   corresponding
Colin>    invocation of va_end() in the same function."

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering