lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jan 2017 22:19:57 -0800 From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> To: "Rafael J. Wysocki" <rjw@...ysocki.net> Cc: Linux ACPI <linux-acpi@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Lv Zheng <lv.zheng@...el.com>, Robert Moore <robert.moore@...el.com>, iommu@...ts.linux-foundation.org Subject: Re: [PATCH] ACPI / DMAR: Avoid passing NULL to acpi_put_table() On Thu, Jan 05, 2017 at 01:24:14AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com> > > Linus reported that commit 174cc7187e6f "ACPICA: Tables: Back port > acpi_get_table_with_size() and early_acpi_os_unmap_memory() from > Linux kernel" added a new warning on his desktop system: > > ACPI Warning: Table ffffffff9fe6c0a0, Validation count is zero before decrement > > which turns out to come from the acpi_put_table() in > detect_intel_iommu(). > > This happens if the DMAR table is not present in which case NULL is > passed to acpi_put_table() which doesn't check against that and > attempts to handle it regardless. > > For this reason, check the pointer passed to acpi_put_table() > before invoking it. > > Reported-by: Linus Torvalds <torvalds@...ux-foundation.org> > Fixes: 6b11d1d67713 ("ACPI / osl: Remove acpi_get_table_with_size()/early_acpi_os_unmap_memory() users") > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> Much better! Tested-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> > --- > drivers/iommu/dmar.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > Index: linux-pm/drivers/iommu/dmar.c > =================================================================== > --- linux-pm.orig/drivers/iommu/dmar.c > +++ linux-pm/drivers/iommu/dmar.c > @@ -903,8 +903,10 @@ int __init detect_intel_iommu(void) > x86_init.iommu.iommu_init = intel_iommu_init; > #endif > > - acpi_put_table(dmar_tbl); > - dmar_tbl = NULL; > + if (dmar_tbl) { > + acpi_put_table(dmar_tbl); > + dmar_tbl = NULL; > + } > up_write(&dmar_global_lock); > > return ret ? 1 : -ENODEV; >
Powered by blists - more mailing lists