linux-kernel - Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1861880.7pouM4E6RB@wuerfel>
Date:   Thu, 05 Jan 2017 23:03:08 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Raviteja Garimella <raviteja.garimella@...adcom.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, linux-usb@...r.kernel.org
Subject: Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote:
> The UDC is based on Synopsys Designware core USB (2.0) Device controller
> IP.
...
> This is a request for comments from maintainers/others regarding approach
> on whether to have 2 different drivers (one each for AMD and Broadcom)
> with a common library (3 files in total), or have a single driver like
> it's done in this patch and have the driver filename changed to some
> common name based on ther underlying IP, like snps_udc.c.

I have not looked at the code at all, so sorry for my ignorance, but
isn't the IP block you describe the one that drivers/usb/dwc2/ is for?
Could you add support for the Broadcom hardware there instead?

	Arnd