linux-kernel - Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170106105610.tr7xv6x5fj2uuqgc@pd.tnic>
Date:   Fri, 6 Jan 2017 11:56:11 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Junichi Nomura <j-nomura@...jp.nec.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] x86/microcode/intel: Fix allocation size of struct
 ucode_patch

On Fri, Jan 06, 2017 at 12:14:13AM +0000, Junichi Nomura wrote:
> Personally I have same opinion as yours. :)
> 
> But according to Documentation/process/coding-style.rst, it seems
> "sizeof(*p)" is preferred style and the reason there makes some
> sense.
> 
> Quote from coding-style.rst:
>   > The preferred form for passing a size of a struct is the following:
>   > 
>   >         p = kmalloc(sizeof(*p), ...);
>   > 
>   > The alternative form where struct name is spelled out hurts readability and
							^^^^^^^^^^^^^^^^^^^^^

Yeah, right. Change is from 2005 (af4e5a218e18a). Pekka didn't know better then. :-P

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.