linux-kernel - [tip:x86/urgent] x86/microcode/intel: Fix allocation size of struct ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2017 14:17:42 -0800
From:   tip-bot for Junichi Nomura <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     j-nomura@...jp.nec.com, mingo@...nel.org, hpa@...or.com,
        bp@...e.de, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86/microcode/intel: Fix allocation size of struct
 ucode_patch

Commit-ID:  9fcf5ba2ef908af916e9002891fbbca20ce4dc98
Gitweb:     http://git.kernel.org/tip/9fcf5ba2ef908af916e9002891fbbca20ce4dc98
Author:     Junichi Nomura <j-nomura@...jp.nec.com>
AuthorDate: Mon, 9 Jan 2017 12:41:46 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 9 Jan 2017 23:11:14 +0100

x86/microcode/intel: Fix allocation size of struct ucode_patch

We allocate struct ucode_patch here. @size is the size of microcode data
and used for kmemdup() later in this function.

Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
Signed-off-by: Jun'ichi Nomura <j-nomura@...jp.nec.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Link: http://lkml.kernel.org/r/7a730dc9-ac17-35c4-fe76-dfc94e5ecd95@ce.jp.nec.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 arch/x86/kernel/cpu/microcode/intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index faec8fa..9434865 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -150,7 +150,7 @@ static struct ucode_patch *__alloc_microcode_buf(void *data, unsigned int size)
 {
 	struct ucode_patch *p;
 
-	p = kzalloc(size, GFP_KERNEL);
+	p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);
 	if (!p)
 		return ERR_PTR(-ENOMEM);