linux-kernel - Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1y3ypgd7m.fsf@oracle.com>
Date:   Thu, 05 Jan 2017 20:59:57 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     James Bottomley <jejb@...ux.vnet.ibm.com>
Cc:     David Miller <davem@...emloft.net>, Bart.VanAssche@...disk.com,
        hch@...radead.org, jbaron@...mai.com, linux-kernel@...r.kernel.org,
        sagi@...mberg.me, sathya.prakash@...adcom.com,
        suganath-prabu.subramani@...adcom.com, martin.petersen@...cle.com,
        hare@...e.de, linux-scsi@...r.kernel.org, hch@....de,
        Sreekanth.Reddy@...adcom.com, chaitra.basappa@...adcom.com,
        dledford@...hat.com
Subject: Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

>>>>> "James" == James Bottomley <jejb@...ux.vnet.ibm.com> writes:

James> Now that I look at the reviews, each of the reviewers said what
James> the correct thing to do was: return SAM_STAT_BUSY if SATL
James> commands are outstanding like the spec says.  You all get
James> negative brownie points for not insisting on a rework.

James> Does this patch (compile tested only) fix the problems for
James> everyone?

I also like this approach better.

Broadcom folks: Please comment and test.

-- 
Martin K. Petersen	Oracle Linux Engineering