linux-kernel - Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VemT--HrzFv3MGDzKNVUBX3y0HV81YPTM32MJ744LWZrQ@mail.gmail.com>
Date:   Fri, 6 Jan 2017 22:48:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michał Kępień <kernel@...pniu.pl>
Cc:     Jonathan Woithe <jwoithe@...t42.net>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to
 properly handle errors

On Fri, Jan 6, 2017 at 9:24 PM, Michał Kępień <kernel@...pniu.pl> wrote:
>> On Thu, Jan 5, 2017 at 3:11 PM, Michał Kępień <kernel@...pniu.pl> wrote:

>> > +       int ret, poweron = FUNC_LED_OFF, always = FUNC_LED_OFF;
>> > +

Don't know if you are already about to send v2, though I would see two
lines of above instead of one.
int ...;
int ret;


-- 
With Best Regards,
Andy Shevchenko