linux-kernel - Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Jan 2017 14:08:53 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     sumit negi <er20snegi@...il.com>
Cc:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Aniket Sharma <badbuddha91@...il.com>,
        Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue

On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote:
> Fixed a camel style issue.

Really?  Look at what you changed:

> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;

mA means something, correct?  Why did you change that?

checkpatch is a _hint_, you still always have to use your brain.  Don't
blindly make changes that make no sense, like this one :(

sorry,

greg k-h