linux-kernel - Re: [GIT PULL] namespace related fixes for 4.10-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170107064012.GI1555@ZenIV.linux.org.uk>
Date:   Sat, 7 Jan 2017 06:40:13 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3

On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote:
> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote:
> 
> > Eric W. Biederman (3):
> >       mnt: Protect the mountpoint hashtable with mount_lock
> ACK
> 
> >       mnt: Tuck mounts under others instead of creating shadow/side mounts.
> 
> NAK; you have reintroduced put_mountpoint() outside of mount lock in there
> and you've got seriously confused umount side of the things.

PS: details are in my reply (admittedly, sent only ~20 minutes
before your pull request) to your patch.  Check Message-ID
<20170107050644.GA12074@...IV.linux.org.uk>

My apologies for not getting to it yesterday (the patch was posted a couple of
days ago, AFAICS) - I'd been off-net since Wednesday, just got back ;-/