lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 8 Jan 2017 12:21:16 -0800 (PST)
From:   Hugh Dickins <>
To:     "Aneesh Kumar K.V" <>
cc:     Hugh Dickins <>,
        Linus Torvalds <>,
        Andrew Morton <>,
        "Kirill A. Shutemov" <>,,,
Subject: Re: [PATCH] mm: stop leaking PageTables

On Sun, 8 Jan 2017, Aneesh Kumar K.V wrote:
> Hugh Dickins <> writes:
> > And fix a separate pagetable leak, or crash, introduced by the same
> > change, that could only show up on some ppc64: why does do_set_pmd()'s
> > failure case attempt to withdraw a pagetable when it never deposited
> > one, at the same time overwriting (so leaking) the vmf->prealloc_pte?
> > Residue of an earlier implementation, perhaps?  Delete it.
> That change is part of -mm tree.

Ah, so it is, I hadn't looked there.  That's reassuring,
I'm glad to know you reached the same conclusion on that piece of code.

It still worried me that the fix is languishing in mmotm, but it looks
not lost: akpm would have sent it in a couple of days anyway, and only
affected ppc64 (like the related khugepaged patch you have queued there).

> >
> > Fixes: 953c66c2b22a ("mm: THP page cache support for ppc64")
> > Signed-off-by: Hugh Dickins <>
> Reviewed-by: Aneesh Kumar K.V <>

Thanks, and to Linus, who already has this in for -rc3: so akpm can drop
and then later send in your


Powered by blists - more mailing lists