linux-kernel - Re: [PATCH] nfc: don't be making arch specific unaligned decisions at driver level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701090805.NVKb2IVs%fengguang.wu@intel.com>
Date:   Mon, 9 Jan 2017 08:47:33 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
        Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
        Samuel Ortiz <sameo@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH] nfc: don't be making arch specific unaligned decisions
 at driver level.

Hi Paul,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc3 next-20170106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paul-Gortmaker/nfc-don-t-be-making-arch-specific-unaligned-decisions-at-driver-level/20170109-082915
config: x86_64-randconfig-x008-201702 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/nfc/nfcmrvl/fw_dnld.c: In function 'process_state_fw_dnld':
>> drivers/nfc/nfcmrvl/fw_dnld.c:287:9: error: implicit declaration of function 'get_unaligned_le16' [-Werror=implicit-function-declaration]
      len = get_unaligned_le16(&len);
            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   drivers/nfc/nxp-nci/firmware.c: In function 'nxp_nci_fw_send_chunk':
>> drivers/nfc/nxp-nci/firmware.c:124:2: error: implicit declaration of function 'put_unaligned_be16' [-Werror=implicit-function-declaration]
     put_unaligned_be16(header, skb_put(skb, NXP_NCI_FW_HDR_LEN));
     ^~~~~~~~~~~~~~~~~~
   drivers/nfc/nxp-nci/firmware.c: In function 'nxp_nci_fw_send':
>> drivers/nfc/nxp-nci/firmware.c:151:25: error: implicit declaration of function 'get_unaligned_be16' [-Werror=implicit-function-declaration]
      fw_info->frame_size = get_unaligned_be16(fw_info->data) &
                            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/get_unaligned_le16 +287 drivers/nfc/nfcmrvl/fw_dnld.c

3194c687 Vincent Cuissard 2015-10-26  281  		}
3194c687 Vincent Cuissard 2015-10-26  282  		skb_pull(skb, 1);
3194c687 Vincent Cuissard 2015-10-26  283  		memcpy(&len, skb->data, 2);
3194c687 Vincent Cuissard 2015-10-26  284  		skb_pull(skb, 2);
3194c687 Vincent Cuissard 2015-10-26  285  		memcpy(&comp_len, skb->data, 2);
3194c687 Vincent Cuissard 2015-10-26  286  		skb_pull(skb, 2);
3194c687 Vincent Cuissard 2015-10-26 @287  		len = get_unaligned_le16(&len);
3194c687 Vincent Cuissard 2015-10-26  288  		comp_len = get_unaligned_le16(&comp_len);
3194c687 Vincent Cuissard 2015-10-26  289  		if (((~len) & 0xFFFF) != comp_len) {
3194c687 Vincent Cuissard 2015-10-26  290  			nfc_err(priv->dev, "bad len complement: %x %x %x",

:::::: The code at line 287 was first introduced by commit
:::::: 3194c6870158e305dac2af52f83681e9cb67280f NFC: nfcmrvl: add firmware download support

:::::: TO: Vincent Cuissard <cuissard@...vell.com>
:::::: CC: Samuel Ortiz <sameo@...ux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27223 bytes)