linux-kernel - Re: [PATCH] nfc: don't be making arch specific unaligned decisions at driver level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701090839.5u37Hdez%fengguang.wu@intel.com>
Date:   Mon, 9 Jan 2017 08:56:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
        Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
        Samuel Ortiz <sameo@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH] nfc: don't be making arch specific unaligned decisions
 at driver level.

Hi Paul,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.10-rc3 next-20170106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paul-Gortmaker/nfc-don-t-be-making-arch-specific-unaligned-decisions-at-driver-level/20170109-082915
config: x86_64-randconfig-x014-201702 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/nfc/nxp-nci/i2c.c: In function 'nxp_nci_i2c_fw_read':
>> drivers/nfc/nxp-nci/i2c.c:129:15: error: implicit declaration of function 'get_unaligned_be16' [-Werror=implicit-function-declaration]
     frame_len = (get_unaligned_be16(&header) & NXP_NCI_FW_FRAME_LEN_MASK) +
                  ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/get_unaligned_be16 +129 drivers/nfc/nxp-nci/i2c.c

6be88670 Clément Perrochaud 2015-03-09  123  	} else if (r != NXP_NCI_FW_HDR_LEN) {
6be88670 Clément Perrochaud 2015-03-09  124  		nfc_err(&client->dev, "Incorrect header length: %u\n", r);
6be88670 Clément Perrochaud 2015-03-09  125  		r = -EBADMSG;
6be88670 Clément Perrochaud 2015-03-09  126  		goto fw_read_exit;
6be88670 Clément Perrochaud 2015-03-09  127  	}
6be88670 Clément Perrochaud 2015-03-09  128  
6be88670 Clément Perrochaud 2015-03-09 @129  	frame_len = (get_unaligned_be16(&header) & NXP_NCI_FW_FRAME_LEN_MASK) +
6be88670 Clément Perrochaud 2015-03-09  130  		    NXP_NCI_FW_CRC_LEN;
6be88670 Clément Perrochaud 2015-03-09  131  
6be88670 Clément Perrochaud 2015-03-09  132  	*skb = alloc_skb(NXP_NCI_FW_HDR_LEN + frame_len, GFP_KERNEL);

:::::: The code at line 129 was first introduced by commit
:::::: 6be88670fc59d50426f90f734a36b90e1de7d148 NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver

:::::: TO: Clément Perrochaud <clement.perrochaud@....com>
:::::: CC: Samuel Ortiz <sameo@...ux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30488 bytes)