[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1483974486.2890.36.camel@synopsys.com>
Date: Mon, 9 Jan 2017 15:08:06 +0000
From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To: Vineet Gupta <Vineet.Gupta1@...opsys.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Igor Guryanov" <Igor.Guryanov@...opsys.com>,
"linux-snps-arc@...ts.infradead.org"
<linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH 1/2] arc: rename xCCM sections so they are not merged in
global .data/.text
Hi Vineet,
On Thu, 2016-12-22 at 16:25 -0800, Vineet Gupta wrote:
> On 12/22/2016 06:09 AM, Alexey Brodkin wrote:
> > diff --git a/arch/arc/include/asm/linkage.h b/arch/arc/include/asm/linkage.h
> > index b29f1a9fd6f7..3a5f13d65ee1 100644
> > --- a/arch/arc/include/asm/linkage.h
> > +++ b/arch/arc/include/asm/linkage.h
> > @@ -28,7 +28,7 @@
> > /* annotation for data we want in DCCM - if enabled in .config */
> > .macro ARCFP_CODE
> > #ifdef CONFIG_ARC_HAS_ICCM
> > - .section .text.arcfp, "ax",@progbits
> > + .section .text..arcfp, "ax",@progbits
>
> Why not turn this around and call it arcfp.text and arcfp.data etc - just like
> done for other special sections such as sched, cpuidle, lock... Just so we are
> consistent with normal kernel convention !
Right that looks much better!
Will do so in v2.
-Alexey
Powered by blists - more mailing lists