linux-kernel - Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread

Open Source and information security mailing list archives

Message-ID: <20170109193328.GO2630@atomide.com>
Date:   Mon, 9 Jan 2017 11:33:28 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Sarangdhar Joshi <spjoshi@...eaurora.org>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Trilok Soni <tsoni@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, Dave Gerlach <d-gerlach@...com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from
 wkup_m3_rproc_boot_thread

* Sarangdhar Joshi <spjoshi@...eaurora.org> [170105 14:01]:
> The function wkup_m3_rproc_boot_thread waits for asynchronous
> firmware loading to parse the resource table before calling
> rproc_boot(). However, as the resource table parsing has been
> moved to rproc_boot(), there's no need to wait for the
> asynchronous firmware loading completion.  So, drop this.
> 
> CC: Dave Gerlach <d-gerlach@...com>
> CC: Bjorn Andersson <bjorn.andersson@...aro.org>
> Tested-by: Suman Anna <s-anna@...com>
> Signed-off-by: Sarangdhar Joshi <spjoshi@...eaurora.org>
> ---
> 
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
> 
> Changes from v2:
> 
> * Updated the subject line as per Suman's comment

FYI, I already have v2 applied with subject:

"soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread"

Tony

>  drivers/soc/ti/wkup_m3_ipc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>  	struct device *dev = m3_ipc->dev;
>  	int ret;
>  
> -	wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
>  	init_completion(&m3_ipc->sync_complete);
>  
>  	ret = rproc_boot(m3_ipc->rproc);
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives