linux-kernel - Re: [PATCH 0/2] sched: Introduce rcuwait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2017 11:37:36 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     mingo@...nel.org, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] sched: Introduce rcuwait

On Tue, 10 Jan 2017, Oleg Nesterov wrote:

>Well, speaking of naming, rcuwait_trywake() doesn't look good to me,
>rcuwait_wake_up() looks better, "try" is misleading imo. But this is
>cosmetic/subjective too.

I actually added the 'try' on second thought -- in that for the particular
pcpu-rwsem user, obviously most of the time the wakeup will not actually
occur. But yeah, I'd have no problem just naming it rcuwait_wake_up().

>Reviewed-by: Oleg Nesterov <oleg@...hat.com>

Thanks!