linux-kernel - Re: [PATCH 1/2] sched: Introduce rcuwait machinery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170116013232.GA7295@linux-80c1.suse>
Date:   Sun, 15 Jan 2017 17:32:32 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     mingo@...nel.org, peterz@...radead.org, oleg@...hat.com
Cc:     linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH 1/2] sched: Introduce rcuwait machinery

On Thu, 22 Dec 2016, Bueso wrote:

>+	WARN_ON(current->exit_state);                                   \

While not related to this patch, but per 3245d6acab9 (exit: fix race
between wait_consider_task() and wait_task_zombie()), should we not
*_ONCE() all things ->exit_state? I'm not really refering to a specific
bug (much less here, where that race would not matter obviously), but
if nothing else, for documentation -- and I doubt it would make any
difference performance wise.

Thanks,
Davidlohr