linux-kernel - Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <138e1558-f4e4-96ce-87d9-7dfcc9e90155@siemens.com>
Date:   Tue, 10 Jan 2017 07:54:35 +0100
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for
 Quark

On 2017-01-10 00:24, Andy Shevchenko wrote:
> On Mon, Jan 9, 2017 at 7:11 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
>> On 2017-01-05 22:56, Andy Shevchenko wrote:
>>> On Thu, Jan 5, 2017 at 1:56 AM, Andy Shevchenko
>>> <andy.shevchenko@...il.com> wrote:
>>>
>>> Ah, Jan, perhaps you would like to comment on this one as well
>>> http://marc.info/?l=linux-serial&m=148334902916347&w=2
>>> ?
>>>
>>
>> http://marc.info/?l=linux-serial&m=148334905916354&w=2 enables MSI, but
>> that's only for Denverton, and there it is unconditional. So this is ok.
> 
> I think there is potential issue, if DMA driver is not compiled or
> probed (by whatever reason) we will have MSI enabled without bus
> mastering.
> And like you said for sake of not copying wrong pattern for new API,
> would be good to move it.

Ah, indeed: the pci_set_master is not yet done unconditionally. Move it
prior to hsu_dma_probe, and everyone should be happy.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux