linux-kernel - Re: [PATCH 3/9] dma: Add dma_virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170111085625.GA15575@infradead.org>
Date:   Wed, 11 Jan 2017 00:56:25 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Bart Van Assche <bart.vanassche@...disk.com>
Cc:     Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Joerg Roedel <jroedel@...e.de>,
        Andy Lutomirski <luto@...nel.org>,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 3/9] dma: Add dma_virt_ops

> +lib-$(CONFIG_HAS_DMA) += dma-virt.o

There probably should be a config option for it for two reasons:

 - do not bloat kernels that don't need it.
 - the feature can only work for 32-bit architectures or for
   64-bit architectures that set ARCH_DMA_ADDR_T_64BIT…
   Altenatiely this option would have to force
   ARCH_DMA_ADDR_T_64BIT when not yet set for 64-bit architectures.

And yes, this is currently broken already for, but we'd better fix it.