linux-kernel - Re: [PATCH 3/9] dma: Add dma_virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2be64d60-9579-4a2a-d38c-8f3ed4a2939f@sandisk.com>
Date:   Wed, 11 Jan 2017 16:07:35 -0800
From:   Bart Van Assche <bart.vanassche@...disk.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     Doug Ledford <dledford@...hat.com>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Joerg Roedel <jroedel@...e.de>,
        Andy Lutomirski <luto@...nel.org>,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 3/9] dma: Add dma_virt_ops

On 01/11/2017 12:56 AM, Christoph Hellwig wrote:
>> +lib-$(CONFIG_HAS_DMA) += dma-virt.o
> 
> There probably should be a config option for it for two reasons:
> 
>  - do not bloat kernels that don't need it.
>  - the feature can only work for 32-bit architectures or for
>    64-bit architectures that set ARCH_DMA_ADDR_T_64BIT…
>    Alternatively this option would have to force
>    ARCH_DMA_ADDR_T_64BIT when not yet set for 64-bit architectures.
> 
> And yes, this is currently broken already for, but we'd better fix it.

Hello Christoph,

That sounds like a good idea to me. I will make sure that both
dma_noop_ops and dma_virt_ops are only built if needed.

Bart.