linux-kernel - Re: [PATCH] afs: correctly use 64-bit time for UUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2360985.j9pqdKkA3M@wuerfel>
Date:   Wed, 11 Jan 2017 15:03:50 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     David Howells <dhowells@...hat.com>
Cc:     Tina Ruchandani <ruchandani.tina@...il.com>,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: correctly use 64-bit time for UUID

On Wednesday, January 11, 2017 1:51:32 PM CET David Howells wrote:
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > From: Tina Ruchandani <ruchandani.tina@...il.com>
> > 
> > UUID calculation uses 'struct timespec' whose seconds will overflow
> > in year 2038 and beyond for 32-bit systems. This patch removes the
> > dependency on 'struct timespec' by using ktime_get_real().
> > While the patch does not fix a 'bug' as such, it is part of a larger
> > effort to remove instances of 'struct timespec' and other data-structures
> > suffering from y2038 problem from the kernel.
> 
> Is it worth abstracting out in-kernel UUID generation?

Do you mean moving it out of AFS into lib/*.c? I think the 'afs_uuid'
structure is quite different from other UUID definitions, so that wouldn't
work.

	Arnd