linux-kernel - Re: [scsi 2/4] scsi: ufs: unexport descritpor reading functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57254b37bdcd7ec94874351355ec9116@codeaurora.org>
Date:   Tue, 10 Jan 2017 16:55:29 -0800
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Tomas Winkler <tomas.winkler@...el.com>
Cc:     James Bottomley <James.Bottomley@...senpartnership.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        Christoph Hellwig <hch@....de>,
        Yaniv Gardi <ygardi@...eaurora.org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [scsi 2/4] scsi: ufs: unexport descritpor reading functions

On 2017-01-05 00:45, Tomas Winkler wrote:
> Unexport ufshcd_read_device_desc and ufshcd_read_string_desc
> there is no really possibility to calling them directly
> outside of UFS context.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 9 ++++-----
>  drivers/scsi/ufs/ufshcd.h | 7 -------
>  2 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index be3c2900b6bb..63d7ae2c3be9 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -2208,11 +2208,10 @@ static inline int
> ufshcd_read_power_desc(struct ufs_hba *hba,
>  	return err;
>  }
> 
> -int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 size)
> +static int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 
> size)
>  {
>  	return ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, buf, size);
>  }
> -EXPORT_SYMBOL(ufshcd_read_device_desc);
> 
>  /**
>   * ufshcd_read_string_desc - read string descriptor
> @@ -2224,8 +2223,9 @@ EXPORT_SYMBOL(ufshcd_read_device_desc);
>   *
>   * Return 0 in case of success, non-zero otherwise
>   */
> -int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 
> *buf,
> -				u32 size, bool ascii)
> +#define ASCII_STD true
> +static int ufshcd_read_string_desc(struct ufs_hba *hba, int 
> desc_index,
> +				   u8 *buf, u32 size, bool ascii)
>  {
>  	int err = 0;
> 
> @@ -2281,7 +2281,6 @@ int ufshcd_read_string_desc(struct ufs_hba *hba,
> int desc_index, u8 *buf,
>  out:
>  	return err;
>  }
> -EXPORT_SYMBOL(ufshcd_read_string_desc);
> 
>  /**
>   * ufshcd_read_unit_desc_param - read the specified unit descriptor 
> parameter
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 08cd26ed2382..00fb82589895 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -713,8 +713,6 @@ static inline int ufshcd_dme_peer_get(struct 
> ufs_hba *hba,
>  	return ufshcd_dme_get_attr(hba, attr_sel, mib_val, DME_PEER);
>  }
> 
> -int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 size);
> -
>  static inline bool ufshcd_is_hs_mode(struct ufs_pa_layer_attr 
> *pwr_info)
>  {
>  	return (pwr_info->pwr_rx == FAST_MODE ||
> @@ -723,11 +721,6 @@ static inline bool ufshcd_is_hs_mode(struct
> ufs_pa_layer_attr *pwr_info)
>  		pwr_info->pwr_tx == FASTAUTO_MODE);
>  }
> 
> -#define ASCII_STD true
> -
> -int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 
> *buf,
> -				u32 size, bool ascii);
> -
>  /* Expose Query-Request API */
>  int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
>  	enum flag_idn idn, bool *flag_res);

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project