lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Jan 2017 16:59:10 -0800 From: Subhash Jadavani <subhashj@...eaurora.org> To: Tomas Winkler <tomas.winkler@...el.com> Cc: James Bottomley <James.Bottomley@...senpartnership.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, Vinayak Holikatti <vinholikatti@...il.com>, Christoph Hellwig <hch@....de>, Yaniv Gardi <ygardi@...eaurora.org>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [scsi 3/4] scsi: ufs: ufshcd_get_max_icc_level fix endianity handling On 2017-01-05 00:45, Tomas Winkler wrote: > Reading big endian value from a buffer requires explicit cast. > Fix sparse warning: > drivers/scsi/ufs/ufshcd.c:4825:24: warning: cast to restricted __be16 > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com> > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 63d7ae2c3be9..fdea08f79b7d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4822,7 +4822,7 @@ static u32 ufshcd_get_max_icc_level(int > sup_curr_uA, u32 start_scan, char *buff) > u16 unit; > > for (i = start_scan; i >= 0; i--) { > - data = be16_to_cpu(*((u16 *)(buff + 2*i))); > + data = be16_to_cpup((__be16 *)&buff[2 * i]); > unit = (data & ATTR_ICC_LVL_UNIT_MASK) >> > ATTR_ICC_LVL_UNIT_OFFSET; > curr_uA = data & ATTR_ICC_LVL_VALUE_MASK; Looks good to me. Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Powered by blists - more mailing lists