linux-kernel - Re: [PATCH] ASoC: rt5651: use msleep for large delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170111145926.22jkebrb7ojemyhq@sirena.org.uk>
Date:   Wed, 11 Jan 2017 14:59:26 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rt5651: use msleep for large delays

On Wed, Jan 11, 2017 at 12:49:36PM +0100, Nicholas Mc Guire wrote:

>  		if (!rt5651->hp_mute)
> -			usleep_range(80000, 85000);
> +			msleep(85);

If you're doing conversions like this I'd expect us to be picking the
lower number rather than the higher number - people are saying "wait for
at least X and at most Y" and msleep() is "wait for at least X" so we
should be picking X.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)