linux-kernel - Re: [PATCH] ASoC: rt5651: use msleep for large delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170111120134.GA15356@osadl.at>
Date:   Wed, 11 Jan 2017 12:01:34 +0000
From:   Nicholas Mc Guire <der.herr@...r.at>
To:     Joe Perches <joe@...ches.com>
Cc:     Nicholas Mc Guire <hofrat@...dl.org>,
        Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rt5651: use msleep for large delays

On Wed, Jan 11, 2017 at 03:55:49AM -0800, Joe Perches wrote:
> On Wed, 2017-01-11 at 12:49 +0100, Nicholas Mc Guire wrote:
> > ulseep_range() uses hrtimers and provides no advantage over msleep()
> > for larger delays. Fix up the 75/85ms delays here to use msleep() and
> > reduce the load on the hrtimer subsystem.
> 
> If this is useful, why not convert all the large value
> usleep_range uses in sound/soc/ ?
>
thats what Im currently doing - just that it cant be done fully
automatic as it may be justified in some cases - so it needs a 
case-by-case review. 

And its not only in sound/soc/ its quite a bit in drivers/ as
well.

thx!
hofrat