linux-kernel - Re: [PATCH] tools: gpio add .gitignore for generated files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda=FdZ+G2rxMAk+WntHSdmm4=L9m=-0goTdAVJ2NnqHpg@mail.gmail.com>
Date:   Wed, 11 Jan 2017 16:19:08 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] tools: gpio add .gitignore for generated files

On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
>>
>>> Add .gitignore for generated files.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>>> ---
>>>  tools/gpio/.gitignore | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>  create mode 100644 tools/gpio/.gitignore
>>>
>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>> new file mode 100644
>>> index 0000000..767ad24
>>> --- /dev/null
>>> +++ b/tools/gpio/.gitignore
>>> @@ -0,0 +1,4 @@
>>> +gpio-event-mon
>>> +gpio-hammer
>>> +lsgpio
>>> +include
>>
>> I understand the first three.
>>
>> But "include"?
>> How did you produce that?
>>
>> Yours,
>> Linus Walleij
>>
>
> I saw this after building selftests. gpio selftests Makefile installs
> headres. "make kselftest" should reproduce the problem. This following
> does an header install from tools/testing/selftests/gpio/Makefile
>
> ../../../../usr/include/linux/gpio.h:
>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

That seems like a bug.

I applied the patch removing the ignore line for include,
I think we should see this until we figured out what we do wrong.

Yours,
Linus Walleij