linux-kernel - Re: [PATCH] tty_port: checkpatch: Refactored file to linux style guides

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2017 08:49:35 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Fabian Arnold <fabian.arnold@....de>
Cc:     devel@...uxdriverproject.org,
        Philip Thiemann <philip.thiemann@....de>,
        linux-kernel@...cs.fau.de, linux-kernel@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH] tty_port: checkpatch: Refactored file to linux style
 guides

On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote:
> The tty_port.c file is now accordingly to the linux style guidelines.

That's the vaguest changelog text ever :(

Please describe what you did here, and why you did it.  And if you fixed
more than one "type" of style issue, you need to break this up into
multiple patches.

And finally, why are you doing checkpatch cleanup on core kernel code?
Please start in drivers/staging/ where it's more appreciated and you can
learn how to do it correctly, that's what that code is there for.

thanks,

greg k-h