linux-kernel - Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d8a7eeb-f49a-47eb-1b74-70631c27e931@amd.com>
Date:   Thu, 12 Jan 2017 13:45:08 +0530
From:   Shyam Sundar S K <ssundark@....com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
CC:     "Agrawal, Nitesh-kumar" <Nitesh-kumar.Agrawal@....com>,
        Pankaj Sen <Pankaj.Sen@....com>,
        "Shah, Nehal-bakulchandra" <Nehal-Bakulchandra.shah@....com>,
        Shyam-sundar S-k <Shyam-sundar.S-k@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

Hi Linus,

You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch.

Do you feel this patch needs to be taken ?

Thanks,
Shyam

On 1/12/2017 1:19 PM, Linus Walleij wrote:
> On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
>> Since gpio_dev->hwbank_num is now a variable, the compiler cannot
>> figure out if pin_num is initialized at all:
>>
>> drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show':
>> drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    for (; i < pin_num; i++) {
>>    ^~~
>> drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>
>> This adds a 'default' statement to make that case well-defined.
>>
>> Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Patch applied.
> 
> Yours,
> Linus Walleij
>