linux-kernel - Re: [PATCH 01/11] perf, tools: Factor out scale conversion code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112133157.GA20003@kernel.org>
Date:   Thu, 12 Jan 2017 10:31:57 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 01/11] perf, tools: Factor out scale conversion code

Em Sun, Jan 08, 2017 at 07:57:53PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> > -		goto error;
> > -
> > -	if (scale[sret - 1] == '\n')
> > -		scale[sret - 1] = '\0';
> > -	else
> > -		scale[sret] = '\0';
> > +	int ret = 0;
> >  
> >  	/*
> >  	 * save current locale
> > @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
> >  	 */
> >  	lc = strdup(lc);
> >  	if (!lc) {
> > -		ret = -ENOMEM;
> > -		goto error;
> > +		ret = -1;
> > +		goto out;
> 
> not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway

These unrelated things are just that, noise, I'll ditch it to reduce
patch size while not introducing any functional change.
 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Will keep your ack tho :-)

- Arnaldo
 
> thanks,
> jirka