linux-kernel - Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112133241.GB20003@kernel.org>
Date:   Thu, 12 Jan 2017 10:32:41 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json
 files

Em Sun, Jan 08, 2017 at 07:58:00PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> >  /*
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 29c254dd7380..8bffe99d8e3f 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -229,11 +229,13 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias,
> >  }
> >  
> >  static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> > -				 char *desc, char *val, char *long_desc,
> > -				 char *topic)
> > +				 char *desc __maybe_unused, char *val,
> 
> no need for 'desc' to be __maybe_unused

I'll check and remove it...

- Arnaldo