linux-kernel - Re: [PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484261382.13165.7.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 12 Jan 2017 14:49:42 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Shannon Nelson <shannon.nelson@...cle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        rob.gardner@...cle.com
Subject: Re: [PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on
 sparc

On Thu, 2017-01-12 at 14:24 -0800, Shannon Nelson wrote:
> Fix up a data alignment issue on sparc by swapping the order
> of the cookie byte array field with the length field in
> struct tcp_fastopen_cookie, and making it a proper union
> to clean up the typecasting.
> 
> This addresses log complaints like these:
>     log_unaligned: 113 callbacks suppressed
>     Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
>     Kernel unaligned access at TPC[9764ac] tcp_try_fastopen+0x2ec/0x360
>     Kernel unaligned access at TPC[9764c8] tcp_try_fastopen+0x308/0x360
>     Kernel unaligned access at TPC[9764e4] tcp_try_fastopen+0x324/0x360
>     Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
> 
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@...cle.com>
> ---
> v2: Use Eric's suggestion for a union in the struct

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks for fixing this !