linux-kernel - Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113083727.GB1446@katana>
Date:   Fri, 13 Jan 2017 09:37:27 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
Cc:     Vladimir Zapolskiy <vz@...ia.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        soren.brinkmann@...inx.com, michal.simek@...inx.com
Subject: Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's
 ready


> I would argue that the "info" message means "the I2C adapter is ready for
> transaction now, and we'll start initializing devices on the bus". That is
> the case before it calls i2c_add_adapter().

I know what you mean, but i2c_add_adapter does more, and it can fail
because the adapter is *not* ready to transfer. Seeing the success
message before is also confusing.

> When i2c_add_adapter() runs, it will start probing devices on the bus. This
> yields very confusing output, as it will output things in a reversed order:
> 
> - device X on I2C bus
> - device Y on I2C bus
> - cdns-i2c ff030000.i2c: 100 kHz mmio ff030000 irq 197

I agree. That being said, somewhen I started working on moving such
messages into the core to save string space and have consistent output.
Then, we can print at the proper time.

So, until then, we should be consistent with the other driver, I'd say.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)