linux-kernel - Re: [PATCH] Input: synaptics-rmi4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170113214240.GA4246@dtor-ws>
Date:   Fri, 13 Jan 2017 13:42:40 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Duggan <aduggan@...aptics.com>,
        Christopher Heiny <cheiny@...aptics.com>,
        Nick Dyer <nick@...anahar.org>, linux-input@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol

On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote:
> On Fri, Jan 13, 2017 at 10:15 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> >
> >>This is my fixup, though I'm not too happy with that version.
> >>
> >>Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >>
> >>diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> >>index 1aeb80e52424..3927259a5d5d 100644
> >>--- a/drivers/hid/Kconfig
> >>+++ b/drivers/hid/Kconfig
> >>@@ -785,7 +785,8 @@ config HID_SUNPLUS
> >> config HID_RMI
> >>       tristate "Synaptics RMI4 device support"
> >>       depends on HID
> >>-      select RMI4_CORE
> >>+      depends on SERIO && RMI4_CORE
> >>+      depends on SERIO=y || RMI4_CORE=SERIO
> >
> > Shouldn't this be simply
> >
> > select SERIO # needed for F03
> 
> Ah, I guess this would work too. I didn't consider it because SERIO is
> a user-visible symbol and we generally try not to 'select' them but instead
> use 'depends on.
> 
> However, SERIO is already used with 'select' all over the place, so adding
> another select is actually safer than adding a dependency (which could
> cause dependency loops here).
> 
> Actually the best solution is probably to have 'select SERIO' in RMI4, like
> 
> config RMI4_F03_SERIO
>        tristate
>        depends on RMI4_CORE
>        depends on RMI4_F03
>        default RMI4_CORE
>        select SERIO
> 
> As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that
> is different from the other SERIO users, it keeps it all in one place,
> and it doesn't
> prevent you from seeing the RMI4_F03 symbol when SERIO=m.

Hmm, if this works and resilient with user changing symbols after
they've been auto-selected then I like it. How can we run it through
multitude of randconfigs?

Thanks.

-- 
Dmitry