linux-kernel - Re: [PATCH] Input: synaptics-rmi4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3cTu8CtxGoSBqEerjN-=5ohTH0KUmnrG5nLcJHYu0yiQ@mail.gmail.com>
Date:   Sat, 14 Jan 2017 13:09:57 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Christopher Heiny <cheiny@...aptics.com>,
        Nick Dyer <nick@...anahar.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-input@...r.kernel.org, Andrew Duggan <aduggan@...aptics.com>
Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol

On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" <dmitry.torokhov@...il.com> wrote:
> On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote:
> > config RMI4_F03_SERIO
> >        tristate
> >        depends on RMI4_CORE
> >        depends on RMI4_F03
> >        default RMI4_CORE
> >        select SERIO
> >
> > As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that
> > is different from the other SERIO users, it keeps it all in one place,
> > and it doesn't
> > prevent you from seeing the RMI4_F03 symbol when SERIO=m.
> Hmm, if this works and resilient with user changing symbols after
> they've been auto-selected then I like it. How can we run it through
> multitude of randconfigs?

I've successfully run it over night on a few hundred randconfig builds without
problems now, so I'm pretty confident it works.

The hidden option will ensure the configuration is always valid even when
the user changes it, the only thing that can be unexpected is the same as
every 'select': when you enable this option, SERIO will get turned on, and
when you disable it again after leaving 'menuconfig', it stays on.

    Arnd