linux-kernel - Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170116092951.3b577463@xeon-e3>
Date:   Mon, 16 Jan 2017 09:29:51 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Philippe Reynes <tremyfr@...il.com>
Cc:     mlindner@...vell.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: marvell: skge: use new api
 ethtool_{get|set}_link_ksettings

On Sat, 14 Jan 2017 13:08:28 +0100
Philippe Reynes <tremyfr@...il.com> wrote:

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
> 
> The callback set_link_ksettings no longer update the value
> of advertising, as the struct ethtool_link_ksettings is
> defined as const.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>

Did you test this on real hardware?