lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jan 2017 12:36:17 -0500 (EST) From: David Miller <davem@...emloft.net> To: stephen@...workplumber.org Cc: tremyfr@...il.com, mlindner@...vell.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings From: Stephen Hemminger <stephen@...workplumber.org> Date: Mon, 16 Jan 2017 09:29:51 -0800 > On Sat, 14 Jan 2017 13:08:28 +0100 > Philippe Reynes <tremyfr@...il.com> wrote: > >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >> The callback set_link_ksettings no longer update the value >> of advertising, as the struct ethtool_link_ksettings is >> defined as const. >> >> Signed-off-by: Philippe Reynes <tremyfr@...il.com> > > Did you test this on real hardware? Philippe probably doesn't have physical access to most of the drivers he is converting. But, he is the only person working on converting all of the drivers, and therefore when the change looks straightforward I am going to reward his work and effort by applying his changes and hope there isn't any fallout. Those who really care can test his patches and give a Tested-by: Thanks.
Powered by blists - more mailing lists