lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jan 2017 19:02:50 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Bartosz Golaszewski <bgolaszewski@...libre.com>, Kevin Hilman <khilman@...nel.org>, Sekhar Nori <nsekhar@...com>, Patrick Titiano <ptitiano@...libre.com>, Michael Turquette <mturquette@...libre.com>, Tejun Heo <tj@...nel.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Russell King <linux@...linux.org.uk>, David Lechner <david@...hnology.com> Cc: linux-ide@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 04/14] sata: ahci-da850: get the sata clock using a connector id Hello! On 01/17/2017 03:26 PM, Bartosz Golaszewski wrote: > In preparation for using two clocks in the driver (the sysclk2-based > clock and the external REFCLK), check if we got a functional clock > after calling ahci_platform_get_resources(). If not, retry calling > get_clk() with con_id specified. clk_get(). > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com> > --- > drivers/ata/ahci_da850.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c > index 267a3d3..18f57c2 100644 > --- a/drivers/ata/ahci_da850.c > +++ b/drivers/ata/ahci_da850.c > @@ -71,12 +71,28 @@ static int ahci_da850_probe(struct platform_device *pdev) > struct ahci_host_priv *hpriv; > struct resource *res; > void __iomem *pwrdn_reg; > + struct clk *clk; > int rc; > > hpriv = ahci_platform_get_resources(pdev); > if (IS_ERR(hpriv)) > return PTR_ERR(hpriv); > > + /* > + * Internally ahci_platform_get_resources() calls clk_get(dev, NULL) > + * when trying to obtain the first clock. This SATA controller uses > + * two clocks for which we specify two connector ids. If we don't It's called connection ID, IIRC. [...] MBR, Sergei
Powered by blists - more mailing lists