linux-kernel - Re: [PATCH] partitions/efi: Fix integer overflow in GPT size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c9bc8f7-7fb8-64d7-f195-7aadfd2cbb14@kernel.dk>
Date:   Tue, 17 Jan 2017 08:03:14 -0800
From:   Jens Axboe <axboe@...nel.dk>
To:     Alden Tondettar <alden.tondettar@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>, linux-efi@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] partitions/efi: Fix integer overflow in GPT size
 calculation

On 01/15/2017 02:31 PM, Alden Tondettar wrote:
> If a GUID Partition Table claims to have more than 2**25 entries, the
> calculation of the partition table size in alloc_read_gpt_entries() will
> overflow a 32-bit integer and not enough space will be allocated for the
> table.
> 
> Nothing seems to get written out of bounds, but later efi_partition() will
> read up to 32768 bytes from a 128 byte buffer, possibly OOPSing or exposing
> information to /proc/partitions and uevents.
> 
> The problem exists on both 64-bit and 32-bit platforms.
> 
> Fix the overflow and also print a meaningful debug message if the table
> size is too large.

Applied for 4.11, thanks.

-- 
Jens Axboe