linux-kernel - Re: [PATCH 04/17] spi: fsl: Use kmalloc_array() in of_fsl_spi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170117182711.l2xsej37mfubn5og@sirena.org.uk>
Date:   Tue, 17 Jan 2017 18:27:11 +0000
From:   Mark Brown <broonie@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-spi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 04/17] spi: fsl: Use kmalloc_array() in
 of_fsl_spi_get_chipselects()

On Fri, Jan 13, 2017 at 06:12:23PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 13 Jan 2017 13:37:25 +0100
> 
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".

The previous patch changed a similar call site to use kcalloc() with a
similar explanation, the choice of function to translate to seems
entirely random since the changelogs don't address the zeroing that
kzalloc() and kcalloc() do but kmalloc() and kmalloc_array() don't.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)