linux-kernel - Re: [PATCH 07/17] spi/mpc52xx: Combine substrings for two messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jan 2017 18:33:17 +0000
From:   Mark Brown <broonie@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-spi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 07/17] spi/mpc52xx: Combine substrings for two messages

On Fri, Jan 13, 2017 at 06:15:54PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 13 Jan 2017 14:14:45 +0100
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: quoted string split across lines
> 
> Thus fix the affected source code places.

You should provide more explanation and analysis for changes than just
saying "checkpatch" - it's not a 100% reliable tool and sometimes it
gives false positives or simply silencing the warning actually makes
things worse (as some of the other feedback on the series shows).  It is
better to provide something in the changelog which explains why the
change improves things, giving credit to checkpatch is of course nice to
do but something that shows an understanding of what it's saying really
helps.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)