linux-kernel - Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170117.154453.1379705071819128189.davem@davemloft.net>
Date:   Tue, 17 Jan 2017 15:44:53 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hch@...radead.org
Cc:     dave.kleikamp@...cle.com, viro@...iv.linux.org.uk,
        sparclinux@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] coredump: Ensure proper size of sparse core
 files

From: Christoph Hellwig <hch@...radead.org>
Date: Mon, 16 Jan 2017 23:55:21 -0800

> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
>> The lseek() done by dump_skip() should extend the file properly.
> 
> lseek never extends a file.  It just moves the current file position.
> So if you do not have a write after the lseek it does nothing.

Ok, then the only other feedback I have is that we should probably
defer this truncate() call until the last possible dump write occurs
rather than right after the VMA loop.