linux-kernel - Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3238f60a-2638-5d9b-4d8d-f9118c90e7b5@oracle.com>
Date:   Tue, 17 Jan 2017 15:01:07 -0600
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     David Miller <davem@...emloft.net>, hch@...radead.org
Cc:     viro@...iv.linux.org.uk, sparclinux@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files

On 01/17/2017 02:44 PM, David Miller wrote:
> From: Christoph Hellwig <hch@...radead.org>
> Date: Mon, 16 Jan 2017 23:55:21 -0800
> 
>> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
>>> The lseek() done by dump_skip() should extend the file properly.
>>
>> lseek never extends a file.  It just moves the current file position.
>> So if you do not have a write after the lseek it does nothing.
> 
> Ok, then the only other feedback I have is that we should probably
> defer this truncate() call until the last possible dump write occurs
> rather than right after the VMA loop.

Yeah. That's fine with me.